Skip to main content

Insecure Use of Dangerous Function

Fixing Command Injection​

About Command Injection

What is command injection?​

Command injection is a type of security vulnerability that allows an attacker to execute arbitrary commands on a target system. It occurs when an application accepts user input as part of a command or query that is executed by the system without proper validation or sanitization.

For example, consider a web application that allows users to search for products by entering a product name. If the application does not properly sanitize user input and passes the input directly to the operating system's command shell, an attacker can insert malicious code into the input that could be executed by the command shell.

This could result in the attacker gaining unauthorized access to the system or performing other malicious actions.

Check out this video for a high-level explanation:

What is the impact of command injection?​

A successful command injection attack can have a wide-ranging impact, depending on the system and the attacker's goals. Here are a few potential impacts:

  • Unauthorized access: An attacker may be able to gain unauthorized access to a system or application, giving them access to sensitive data or functionality.
  • Data theft: An attacker may be able to steal data from the system, including personally identifiable information, financial data, or other sensitive data.
  • Malware installation: An attacker may be able to install malware on the system, allowing them to further compromise the system or use it as a launching point for other attacks.
  • Denial of service: An attacker may be able to launch a denial-of-service attack by executing commands that overwhelm the system's resources, or deleting important system files.
  • System compromise: In some cases, a successful command injection attack can lead to complete compromise of the system, allowing the attacker to take full control.

How to prevent command injection?​

Some measures that can help prevent command injection attacks are:

  • Input validation and sanitization: Ensure that user input is validated and sanitized before it is used in any system command. Use regular expressions or input filters to remove or encode any special characters that could be used to execute arbitrary commands.
  • Use parameterized queries: When executing commands that include user input, use parameterized queries instead of string concatenation.
  • Limit permissions: Limit the permissions of the user account that runs the application to only those that are necessary to perform its functions.
  • Perform regular security audits: Regularly audit your system and application for security vulnerabilities, including command injection vulnerabilities. Use automated tools and manual testing to identify potential issues and fix them before they can be exploited.
  • Educate your development team: Educate your development team about the risks of command injection attacks and the measures that can be taken to prevent them.

References​

Taxonomies​

Explanation & Prevention​

Training​

Ruby offers several ways to execute operating system commands, such as:

  • exec(command)
  • syscall(command)
  • system(command)
  • eval()
  • constantize()
  • render()

Option A: Replace the dangerous function with a secure alternative​

Solution-specific references:

  1. Go through the issues that GuardRails identified in the PR/MR

  2. Locate the dangerous function. For example:

    # One example is exec, but many other dangerous functions exist in Ruby.
    exec("/path/to/cmd #{params[:input]}")

  3. If the functionality is not required, then remove it

  4. Otherwise, replace the dangerous function with the following:

    # The key point is that the user input is in the second part of the Array
    # that is passed to the system function.
    # Make sure that no user input is in the first part of the Array that
    # contains the command itself.
    system("/path/to/cmd","#{params[:input]}")

  5. Test it and ensure the functionality works as expected

  6. Ship it 🚢 and relax 🌴

Fixing Code Injection​

About Code Injection

What is code injection?​

Code injection is a security vulnerability that occurs when an application generates code dynamically and does not properly validate or sanitize user input before using it to generate the code.

The main difference between command injection and code injection is that command injection focuses on executing arbitrary system commands, while code injection focuses on injecting and executing arbitrary code within a program or system.

Code Injection is limited by the functionality of the injected language itself.

Check out this video for a high-level explanation:

What is the impact of code injection?​

A successful code injection attack can have a wide-ranging impact, depending on the system and the attacker's goals. Here are a few potential impacts:

  • Unauthorized access: An attacker may be able to gain unauthorized access to a system or application, giving them access to sensitive data or functionality.
  • Data theft: An attacker may be able to steal data from the system, including personally identifiable information, financial data, or other sensitive data.
  • Malware installation: An attacker may be able to install malware on the system, allowing them to further compromise the system or use it as a launching point for other attacks.
  • Denial of service: An attacker may be able to launch a denial-of-service attack by executing code that overwhelms the system's resources.
  • System compromise: In some cases, a successful code injection attack can lead to the complete compromise of the system.

How to prevent code injection?​

Some measures that can help prevent code injection attacks are:

  • Input validation and sanitization: Ensure that user input is validated and sanitized before it is used to generate code.
  • Perform regular security audits: Regularly audit your system and application for security vulnerabilities, including code injection vulnerabilities. Use automated tools and manual testing to identify potential issues and fix them before they can be exploited.
  • Educate your development team: Educate your development team about the risks of code injection attacks and the measures that can be taken to prevent them.

References​

Taxonomies​

Explanation & Prevention​

Training​

Option A: Using constantize safely​

Solution-specific references:

  1. Go through the issues that GuardRails identified in the PR/MR

  2. Locate the constantize method. A vulnerable example is:

    class AlertsController < ApplicationController
      def create
        params[:alert][:type].constantize.new(params[:alert][:value])  # <-- bad code don't do this!
        # ... other work
        # render page
      end
    end

  3. If the functionality is not required, then remove it

  4. Otherwise, apply the following pattern:

    # Some file where a constant definition is appropriate.
    ALERTS = {
      'info' => InfoAlert,
      'warn' => WarnAlert,
      'error' => ErrorAlert
    }

    class AlertsController < ApplicationController
      def create
        ALERTS.fetch(params[:alert][:type])).new(params[:alert][:value]))

        # ... other work
        # render page
      end
    end

  5. Test it and ensure the functionality works as expected

  6. Ship it 🚢 and relax 🌴

Option B: Restrict Allowed Input to Render()​

Solution-specific references:

  1. Go through the issues that GuardRails identified in the PR/MR

  2. Locate the render method. A vulnerable example is:

    def show
      render params[:template]
    end

  3. Apply the following pattern:

    def show
      template = params[:id]

      valid_templates = {
        "dashboard" => "dashboard",
        "profile"   => "profile",
        "deals"   => "deals"
      }

      if valid_templates.include?(template)
        render " #{valid_templates[template]}"
      else
        # throw exception or 404
      end
    end

  4. Test it and ensure the functionality works as expected

  5. Ship it 🚢 and relax 🌴

Last updated on by Stefan Streichsbier